Skip to content

fix(compiler/mysql): prevent panic in convertSetOprSelectList() #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

fix(compiler/mysql): prevent panic in convertSetOprSelectList() #4042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions internal/endtoend/testdata/select_union/mysql/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion internal/endtoend/testdata/select_union/mysql/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,9 @@ SELECT * FROM foo;
-- name: SelectUnionOther :many
SELECT * FROM foo
UNION
SELECT * FROM bar;
SELECT * FROM bar;

-- name: SelectUnionAliased :many
(SELECT * FROM foo)
UNION
SELECT * FROM bar;
26 changes: 26 additions & 0 deletions internal/endtoend/testdata/select_union/postgres/pgx/v4/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion internal/endtoend/testdata/select_union/postgres/pgx/v4/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,9 @@ SELECT * FROM foo;
-- name: SelectUnionOther :many
SELECT * FROM foo
UNION
SELECT * FROM bar;
SELECT * FROM bar;

-- name: SelectUnionAliased :many
(SELECT * FROM foo)
UNION
SELECT * FROM foo;
26 changes: 26 additions & 0 deletions internal/endtoend/testdata/select_union/postgres/pgx/v5/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion internal/endtoend/testdata/select_union/postgres/pgx/v5/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,9 @@ SELECT * FROM foo;
-- name: SelectUnionOther :many
SELECT * FROM foo
UNION
SELECT * FROM bar;
SELECT * FROM bar;

-- name: SelectUnionAliased :many
(SELECT * FROM foo)
UNION
SELECT * FROM foo;
29 changes: 29 additions & 0 deletions internal/endtoend/testdata/select_union/postgres/stdlib/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion internal/endtoend/testdata/select_union/postgres/stdlib/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,9 @@ SELECT * FROM foo;
-- name: SelectUnionOther :many
SELECT * FROM foo
UNION
SELECT * FROM bar;
SELECT * FROM bar;

-- name: SelectUnionAliased :many
(SELECT * FROM foo)
UNION
SELECT * FROM foo;
2 changes: 1 addition & 1 deletion internal/endtoend/testdata/select_union/sqlite/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ SELECT * FROM foo;
-- name: SelectUnionOther :many
SELECT * FROM foo
UNION
SELECT * FROM bar;
SELECT * FROM bar;
7 changes: 6 additions & 1 deletion internal/engine/dolphin/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,12 @@ func (c *cc) convertSetOprType(n *pcast.SetOprType) (op ast.SetOperation, all bo
func (c *cc) convertSetOprSelectList(n *pcast.SetOprSelectList) ast.Node {
selectStmts := make([]*ast.SelectStmt, len(n.Selects))
for i, node := range n.Selects {
selectStmts[i] = c.convertSelectStmt(node.(*pcast.SelectStmt))
switch node := node.(type) {
case *pcast.SelectStmt:
selectStmts[i] = c.convertSelectStmt(node)
case *pcast.SetOprSelectList:
selectStmts[i] = c.convertSetOprSelectList(node).(*ast.SelectStmt)
}
}

op, all := c.convertSetOprType(n.AfterSetOperator)
Expand Down
Loading