fix(compiler): Pull in array information from analyzer #2864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| ` | ||
| | ||
| type UpdateAuthorParams struct { | ||
| Names int32 |
There was a problem hiding this comment.
This is fine to merge, but the field name is a bit unfortunate. Would be better as NameIndex or similar, but I don't know how hard that is to special-case.
andrewmbenton approved these changes Oct 18, 2023
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
* fix(compiler): Pull in array information from analyzer Fixes sqlc-dev#1532 * test(analyzer): Add testcase for sqlc-dev#1574 * test: Added test for sqlc-dev#1634 * test: Add test case for sqlc-dev#1646 * test: Add test for sqlc-dev#1714 * Fixes sqlc-dev#1912 * test: Add case for sqlc-dev#1916 * test: Add two test cases sqlc-dev#1917 sqlc-dev#1545 * test: Add case for sqlc-dev#1979 * test: Add case for sqlc-dev#1990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1532