adds mysql support for custom sqlc.arg(MyParam) params #275
Conversation
cmoog changed the title sqlc.arg(MyParam) paramssqlc.arg(MyParam) params 
internal/mysql/param_test.go Outdated
| tests := []testCase{ | ||
| testCase{ | ||
| input: "INSERT INTO users (first_name, last_name) VALUES (?, ?)", | ||
| input: "INSERT INTO users (first_name, last_name) VALUES (?, sqlc.arg(UserLastName))", |
There was a problem hiding this comment.
One thing I didn't mention in #71. I'm not sure we should allow mixing ? and sqlc.arg(). Thoughts?
| I just added the requested test changes. I also included an example in |
| Thoughts about mixing parameter types? I think it will only lead to confusion. |
I can certainly imagine times when I'd want to only have one argument name override in complex queries with 5+ arguments. In those cases, mixing |
kyleconroy left a comment
kyleconroy left a comment There was a problem hiding this comment.
The last thing we need to do is function call validation. If someone calls sqlc.arg with incorrect parameters, we want to return a helpful error message. Here are some of the mistakes that people might make:
sqlc.arg.name sqlc.arh(param) sqlc.arg(?) sqlc.arg('param') sqlc.arg(sqlc.arg(param)) 
| Just added proper error messages for the last four examples. The first example already returns a reasonably helpful message from the column schema validation. |
2 participants
Adds functionality described in #71
As is, the current implementation supports both
sqlc.arg(ParamName)and:ParamName.