Skip to content

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Aug 2, 2023

fix #2559

Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For end-to-end tests, the query should be consistent across engines. In this particular case, either create a new end-to-end test or create a second named query in query.sql, adding it to the MySQL and PostgreSQL test cases as well.

@orisano
Copy link
Contributor Author

orisano commented Aug 2, 2023

@kyleconroy fixed!

@andrewmbenton
Copy link
Collaborator

I think this will need a rebase or merge from main to get tests running again.

@orisano
Copy link
Contributor Author

orisano commented Aug 2, 2023

@andrewmbenton rebased!

@andrewmbenton
Copy link
Collaborator

Looks good to me. @kyleconroy do these tests look alright?

@andrewmbenton andrewmbenton merged commit 973068d into sqlc-dev:main Aug 2, 2023
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
…dev#2560) * fix(engine/sqlite): fixed detection of column alias without AS fix sqlc-dev#2559 * test: update endtoend * test: update endtoend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants