Add a few types, export DBTX #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This change includes several enhancements: 1. Add the `blob` type 2. Add the `inet` type and import for the `"net"` package as necessary 3. Fixes the "uses" functions so that they work with array columns 4. Export the `DBTX` interface. The unexported type didn't play well with [wire](https://github.com/google/wire) which needs concrete types which requires them to be exported. That said, since this interface is always the same, maybe there should be a type directly exported by sqlc, e.g. `"github.com/kyleconroy/sqlc.DBTX"` instead. 5. Fixes some minor lint issues Signed-off-by: Joshua Rubin <me@jawa.dev>
| Thanks for the pull request. I knew that name looked familiar when I got the email about this PR :) The changes look good. As for adding the interface to |
| Great, thanks for responding so quickly! I'm not certain if this contains all the changes I need for this project, so there might be more coming. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change includes several enhancements:
blobtypeinettype and import for the"net"package as necessaryDBTXinterface. The unexported type didn't play well with wire which needs concrete types which requires them to be exported. That said, since this interface is always the same, maybe there should be a type directly exported by sqlc, e.g."github.com/kyleconroy/sqlc.DBTX"instead.