passing selected row to the prediction result table #3098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sneaxiy reviewed Nov 9, 2020
python/runtime/tensorflow/predict.py Outdated
| | ||
| with db.buffered_db_writer(conn, result_table, column_names, 100) as w: | ||
| for features in pred_dataset: | ||
| for features, (row, _) in zip(pred_dataset, predict_generator()): |
There was a problem hiding this comment.
I wonder if the result order of the SELECT ... statement is always deterministic? I mean: does the data order of pred_dataset can always be the same as predict_generator?
There was a problem hiding this comment.
dataset is generated by generator, according to the source code of from_generator, it stays the same order expect calling shuffle
Codecov Report
@@ Coverage Diff @@ ## develop #3098 +/- ## =========================================== + Coverage 50.88% 50.93% +0.04% =========================================== Files 248 248 Lines 18447 18493 +46 =========================================== + Hits 9387 9419 +32 - Misses 8364 8378 +14 Partials 696 696
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixed #3090