Retain build-essential and python3-dev in the step image. #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brightcoder01 requested review from lhw362950217, sneaxiy, typhoonzero and weiguoz 
weiguoz reviewed Aug 27, 2020
| && choose_fastest_pip_source; fi' && \ | ||
| apt-get update && \ | ||
| apt-get -qq install -y --no-install-recommends openjdk-8-jre-headless python3 libmysqlclient20 python3-idna libgomp1 python3-setuptools python3-pip && \ | ||
| apt-get -qq install -y --no-install-recommends openjdk-8-jre-headless python3 libmysqlclient20 python3-idna libgomp1 python3-setuptools python3-pip build-essential python3-dev && \ |
There was a problem hiding this comment.
Do we need both python3 and python3-dev?
There was a problem hiding this comment.
python3-dev has dependency on python3. Installing python3-dev will trigger the python3 installation automatically. Keeping both is also fine because it won't bring additional overhead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It's common that we will build the runnable images based on the base image - sqlflow/sqlflow:step and then install additional python packages. Some python packages such as
psutilneed compilation which requires gcc andPython.h. In order the prepare the compilation environment in the base image, we will retain build-essential and python3-dev packages in sqlflow/sqlflow:step.