Skip to content

Allow 0 to be a valid UUID #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
holloway merged 2 commits into from
Aug 1, 2021
Merged

Allow 0 to be a valid UUID #325

holloway merged 2 commits into from
Aug 1, 2021

Conversation

@gavinhenderson
Copy link
Contributor

@gavinhenderson gavinhenderson commented Jul 30, 2021

Fixes #324

Changes made:

  • Use nullish coalescing to check if a UUID is given rather than a falsy check
  • Change UUID type to be a string or number
  • Add a regression test
aviranbergic
aviranbergic approved these changes Aug 1, 2021
View reviewed changes
Copy link

@aviranbergic aviranbergic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much appreciated change!
holloway
holloway approved these changes Aug 1, 2021
View reviewed changes
Copy link

@holloway holloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, nice one!
@holloway holloway merged commit 51a38ae into springload:master Aug 1, 2021
@holloway
Copy link

holloway commented Aug 1, 2021

Released as version 3.3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@gavinhenderson @holloway @aviranbergic