Added error handling around "duplicate" request handlers #2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…e infinite loop in ModelAttributeParameterExpander StackOverflowError
…e infinite loop in ModelAttributeParameterExpander StackOverflowError
mate1983 commented Oct 10, 2017
| } catch (Error e) { | ||
| String contentMsg = "Process path[" + path + "],method[" + methodName + "] error"; | ||
| log.error(contentMsg, e); | ||
| throw new Error(contentMsg, e); |
Author
There was a problem hiding this comment.
becase the log impl is slf4j,but not all log impl is it ,so new Error object and join the msg
Codecov Report
@@ Coverage Diff @@ ## master #2066 +/- ## ============================================ - Coverage 95.77% 95.71% -0.07% - Complexity 2734 2735 +1 ============================================ Files 317 317 Lines 5995 6001 +6 Branches 494 494 ============================================ + Hits 5742 5744 +2 - Misses 146 150 +4 Partials 107 107 |
ghost removed the 
dilipkrish changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
add log and try/catch for find StackOverflowError in which api and method。
Are there unit tests? If not how should this be manually tested?
have unit tests
Any background context you want to provide?
yes
What are the relevant issues?