Update PropertySourcedRequestMappingHandlerMapping.java #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mappingPath method used a unresolved value as property lockup key. So by default we were looking for "${springfox.documentation.swagger.v2.path}" property instead of "springfox.documentation.swagger.v2.path" 
Codecov Report
@@ Coverage Diff @@ ## master #1806 +/- ## ======================================== Coverage 91.4% 91.4% Complexity 2515 2515 ======================================== Files 299 299 Lines 5761 5761 Branches 478 478 ======================================== Hits 5266 5266 Misses 412 412 Partials 83 83 |
Member
| Thanks for the finding that and for the PR! 🙇 |
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
mappingPath method used a unresolved value as property lockup key.
So by default we were looking for "${springfox.documentation.swagger.v2.path}" property instead of "springfox.documentation.swagger.v2.path"
Because of this bug it was impossible to use springfox.documentation.swagger.v2.path property to change default mapping.