Migrate Redis session repositories from DisposableBean to SmartLifecycle #3460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace DisposableBean with SmartLifecycle in RedisIndexedSessionRepository and ReactiveRedisIndexedSessionRepository to improve compatibility with Spring Data Redis connection factories. Fixes spring-projects#3435 Signed-off-by: seung-hun-h <dau4723@gmail.com>
spring-projects-issues added the status: waiting-for-triage 
seung-hun-h force-pushed the feature/redis-disposalbean-to-lifecycle-3.3.x branch from 1d5b7d4 to cdca5cb Compare seung-hun-h force-pushed the feature/redis-disposalbean-to-lifecycle-3.3.x branch from 6a9df4b to cdca5cb Compare Signed-off-by: seung-hun-h <dau4723@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR migrates RedisIndexedSessionRepository and ReactiveRedisIndexedSessionRepository from DisposableBean to SmartLifecycle to resolve compatibility issues with Spring Data Redis connection factories. The change ensures proper shutdown ordering and prevents Redis connection errors during application shutdown.
Changes
Related Issue
Fixes #3435