Remove Java 8 requirement from sample function app #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This removes the previous requirement for the sample-signup-app to target Java 8. It was required due to a now non-existent limitation in the Pulsar functions client. It also removes the previous requirement for the sample-signup-app to use Pulsar client version `4.0.5`. It was required due to a limmitation in the Pulsar version `4.0.6` which has since been addressed in Pulsar `4.0.6+`. Therefore, the Pulsar version used in now derived from the Gradle platform. Signed-off-by: onobc <chris.bono@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This removes the previous requirement for the sample-signup-app to target Java 8. It was required due to a now non-existent limitation in the Pulsar functions client.
It also removes the previous requirement for the sample-signup-app to use Pulsar client version
4.0.5. It was required due to a limmitation in the Pulsar version4.0.6which has since been addressed in Pulsar4.0.6+. Therefore, the Pulsar version used in now derived from the Gradle platform.