Fix NPE when GraphQL argument is a list with a null element #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In case of collection-argument with nullable items.
| @turboezh Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
| @turboezh Thank you for signing the Contributor License Agreement! |
spring-projects-issues added the status: waiting-for-triage 
rstoyanchev added type: enhancement rstoyanchev changed the title Contributor Author
| Hi, @rstoyanchev. This request was made based on the main branch and I guess this is not a right way. I've made a new one (#486) based on 1.0.x. |
Contributor
| Thanks. Keep in mind that we do rebase the PR onto 1.0.x or on top of the latest in main, depending on the target milestones, so typically no need to be concerned with this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In case of collection-argument with nullable items.
Passing null items in collection-argument causes NPE in
org.springframework.graphql.data.GraphQlArgumentBinder#createCollection:Cannot invoke "Object.getClass()" because "rawValue" is null.Test case:
Schema:
Query:
{ theData(idList: ["123", null, "234"]) }