Extend and improve some test cases #36018
Open
+99 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
CollectionUtilsTests: - Every case must be run with a fresh enumeration - Extend test cases with non-existing element ExponentialBackOffTests: - Rename test case to better reflect what it does - Extend test case with jitter functionality BooleanComparatorTests: - Extend test cases to be more exhaustive Signed-off-by: Vincent Stradiot <vincentstradiot@hotmail.com>
spring-projects-issues added the status: waiting-for-triage AssertTests.isNullWithNonNullObject Signed-off-by: Vincent Stradiot <vincentstradiot@hotmail.com>
Add test cases that cover BeanFactoryUtils.uniqueBean method Signed-off-by: Vincent Stradiot <vincentstradiot@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi, here is a Pull Request that extends and improves some test cases.
CollectionUtilsTest, it seems important to me to run each case/assert with a fresh enumeration. Otherwise, the test cases are not independent as we might already have enumerated some elements in case 1 when running case 2.Thank you for the review, and have a nice day.