Skip to content

Conversation

@rlaehd62
Copy link

@rlaehd62 rlaehd62 commented Nov 17, 2024

Change

  • Improve readability by deleting unnecessary 'else'.
  • Improve readability by adding early return.
@pivotal-cla
Copy link

@rlaehd62 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@rlaehd62 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 17, 2024
@sbrannen
Copy link
Member

Hi @rlaehd62,

Congratulations on submitting your first PR for the Spring Framework! 👍

Unfortunately, the proposed changes pertain mainly to topics that are a matter of style, and we typically do not like to make changes based solely on style. In addition, if-else blocks sometimes actually make it easier to reason about the code at a glance.

In light of that, I am closing this PR.

Cheers,

Sam

@sbrannen sbrannen closed this Nov 17, 2024
@sbrannen sbrannen added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 17, 2024
@rlaehd62 rlaehd62 deleted the spring-core-util-rlaehd62 branch November 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

4 participants