Use new Java features (switch expressions, text blocks, new JDK methods) #29747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
spring-projects-issues added the status: waiting-for-triage 
sbrannen added type: task sbrannen changed the title 
sbrannen reviewed Jan 11, 2023
| Content-Length: 6\r | ||
| \r | ||
| myBody\r | ||
| """); |
Member
There was a problem hiding this comment.
Instead of manually appending \r to every line in a text block, we prefer to write text blocks as "plain text" and then adjust the line endings only if necessary.
For example, in this particular case we would remove all \r entries and apply .replace("\n", "\r\n") to the text block.
NO need to make these changes in this PR though. I have already applied such changes locally which will be pushed to main along with your PR.
Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Converted few cases where new switch statements/expressions make the code more readable.
Few cases of multi line strings where converted to text blocks (unfortunately there is an issue of tabs/spaces because checkstyle doesn't know it is in textblock).
Also uses new methods to read strings directly.