Use switch expressions in SpEL's CodeFlow #29020
Conversation
| @r331 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues added the status: waiting-for-triage | @r331 Thank you for signing the Contributor License Agreement! |
| case 'J' -> mv.visitInsn(I2L); | ||
| case 'I' -> { //nop | ||
| } | ||
| default -> throw new IllegalStateException("Unexpected value: " + targetDescriptor); |
There was a problem hiding this comment.
The stackTop information is no longer present in the exception message.
| default -> throw new IllegalStateException("Unexpected value: " + targetDescriptor); | |
| default -> throw new IllegalStateException("Cannot get from " + stackTop + " to " + targetDescriptor); |
sbrannen added type: task 
| | ||
| /** | ||
| * Name of the class being generated. Typically used when generating code | ||
| * Name of the class being generated. Typically, used when generating code |
There was a problem hiding this comment.
That was grammatically correct as it was. "Typically" is an adverb modifying the verb "used".
| */ | ||
| public static void insertUnboxNumberInsns( | ||
| MethodVisitor mv, char targetDescriptor, @Nullable String stackDescriptor) { | ||
| |
There was a problem hiding this comment.
Please refrain from deleting blank lines intentionally inserted by the original authors.
| } | ||
| else { | ||
| throw new IllegalStateException("Cannot get from " + stackTop + " to " + targetDescriptor); | ||
| if (!CodeFlow.isPrimitive(stackDescriptor)) return; |
There was a problem hiding this comment.
In Spring Framework, we do not use single-line if-statements.
| case "char" -> "C"; | ||
| case "long" -> "J"; | ||
| case "void" -> "V"; | ||
| default -> throw new IllegalStateException("Unexpected value: " + name); |
There was a problem hiding this comment.
I'd use the same exception message here that you use below: "Unknown primitive type: " + name.
sbrannen changed the title CodeFlow 
| @r331, for future reference please ensure that you always run a full local build before submitting a PR. For example, this PR actually fails the build due to Checkstyle violations. |
5 participants
On the way to Spring 6 and java 17 - refactoring the class CodeFlow. Instead of if-else, I added more readable switch expressions.