Give spring-core access to jdk.unsupported for Objenesis support on WildFly #25852
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a Dependencies manifest entry with the value jdk.unsupported to
spring-core.
Objenesis repackaged in Spring Core needs access to
sun.reflect.ReflectionFactorylocated in thejdk.unsupportedmodule. WildFly by default restricts applications from accessing thejdk.unsupportedmodule (WFCORE-4055). This leads to obscure exceptions like #21528. In our case the default constructor of a Spring Batch job scoped bean could not be found. This was confusing because the bean had an autowired non-default constructor. The problem and solution were not obvious to us.To give Objenesis in spring-core access to the
jdk.unsupportedmodule users need to do either of the following:As Spring Core uses a repackaged Objenesis we can instead add the
Dependenciesmanifest header to spring-core itself making things "just work"(tm) for Spring users on WildFly.