Skip to content

Refact iterator of Map with Java 8 forEach #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
diguage wants to merge 8 commits into from
Closed

Refact iterator of Map with Java 8 forEach #1447

diguage wants to merge 8 commits into from

Conversation

@diguage
Copy link
Contributor

@diguage diguage commented Jun 4, 2017

No description provided.

@diguage
Copy link
Contributor Author

diguage commented Jun 4, 2017 •
edited
Loading

I'm sorry.

I use Gerrit in the work.So I follow the flow of Gerrit. I rebase master to the PR branch: diguage@java8-map$ git rebase master. I may break the commit log.

Need I fix the log? How to fix?
lqjack
lqjack reviewed Jun 5, 2017
View reviewed changes
Copy link

@lqjack lqjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use stream.collect(Collectors.toMap) instead of inserting the items using forEach.

thanks
@diguage
Copy link
Contributor Author

diguage commented Jun 5, 2017

@lqjack I send a email to you. Let's talk about your comment. Thanks.
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jun 5, 2017 •
edited
Loading

I'm closing this PR since the commits look wrong. Please re-submit with correct commits. It's hard to tell what exactly happened. I would suggest starting on a fresh branch and try to cherry-pick the commits that you actually want to submit.

As a general comment don't worry too much about always rebasing on top of the latest in master. It is a moving target so there is bound to be some extra commits after yours, which is okay. We will rebase when processing the PR.
@rstoyanchev rstoyanchev closed this Jun 5, 2017
@diguage diguage deleted the java8-map branch June 5, 2017 16:11
@diguage
Copy link
Contributor Author

diguage commented Jun 5, 2017

@rstoyanchev I resubmit the changes. #1451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@diguage @rstoyanchev @lqjack @snicoll