Skip to content

HttpOnly Cookie Result Matcher #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhoeller merged 1 commit into from
Apr 27, 2017
Merged

HttpOnly Cookie Result Matcher #1373

jhoeller merged 1 commit into from
Apr 27, 2017

Conversation

@lc-nyovchev
Copy link

@lc-nyovchev lc-nyovchev commented Apr 4, 2017 •
edited
Loading

Added a httpOnly cookie ResultMatcher in spring test web SPR-15488

Also, FIxed a small typo in a String var ("unknowCookie" to "unknownCookie")

Basically it allows us to do the following:

@Test public void someTest(){ .... Cookie cookie = result.getResponse().getCookie(name); assertEquals("Response cookie httpOnly", httpOnly, cookie.isHttpOnly()); }
@pivotal-issuemaster
Copy link

pivotal-issuemaster commented Apr 4, 2017

@lc-nyovchev Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.
@pivotal-issuemaster
Copy link

pivotal-issuemaster commented Apr 4, 2017

@lc-nyovchev Thank you for signing the Contributor License Agreement!
lc-nyovchev
lc-nyovchev commented Apr 5, 2017
View reviewed changes
...springframework/test/web/servlet/samples/standalone/resultmatchers/CookieAssertionTests.java Outdated
Copy link
Author

@lc-nyovchev lc-nyovchev Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo
@jhoeller jhoeller merged commit d9bde08 into spring-projects:master Apr 27, 2017
@spring-projects-issues spring-projects-issues mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@lc-nyovchev @pivotal-issuemaster @jhoeller