DATAREST-937 - Transient properties in JSON should be included in merge #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
candrews changed the title candrews force-pushed the transientproperties branch from 2e76e01 to ec5b9b1 Compare | @olivergierke is there anything else I can do to help get this into the next release? |
| Currently not, thanks. |
odrotbohm pushed a commit that referenced this pull request Dec 6, 2016
We now don't prematurely drop fields that don't have a persistent property exposed in DomainObjectReader. Doing so dropped values for transient fields as the latter are not exposed as persistent property in the first place. We still skip any nested merging though. Original pull request: #240.
odrotbohm added a commit that referenced this pull request Dec 6, 2016
Moved the newly added test case to the end of the list. Formatting. Original pull request: #240.
odrotbohm pushed a commit that referenced this pull request Dec 6, 2016
We now don't prematurely drop fields that don't have a persistent property exposed in DomainObjectReader. Doing so dropped values for transient fields as the latter are not exposed as persistent property in the first place. We still skip any nested merging though. Original pull request: #240.
odrotbohm added a commit that referenced this pull request Dec 6, 2016
Moved the newly added test case to the end of the list. Formatting. Original pull request: #240.
odrotbohm pushed a commit that referenced this pull request Dec 6, 2016
We now don't prematurely drop fields that don't have a persistent property exposed in DomainObjectReader. Doing so dropped values for transient fields as the latter are not exposed as persistent property in the first place. We still skip any nested merging though. Original pull request: #240.
odrotbohm added a commit that referenced this pull request Dec 6, 2016
Moved the newly added test case to the end of the list. Formatting. Original pull request: #240.
odrotbohm pushed a commit that referenced this pull request Dec 6, 2016
We now don't prematurely drop fields that don't have a persistent property exposed in DomainObjectReader. Doing so dropped values for transient fields as the latter are not exposed as persistent property in the first place. We still skip any nested merging though. Original pull request: #240.
odrotbohm added a commit that referenced this pull request Dec 6, 2016
Moved the newly added test case to the end of the list. Formatting. Original pull request: #240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
DATAREST-937 - Transient properties in JSON should be included in merge
https://jira.spring.io/browse/DATAREST-937