Resolution for DATAREST-763 #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added URL encoding/decoding and special case handling for '/' character.
spring-projects-issues added the status: waiting-for-triage 
odrotbohm force-pushed the main branch 3 times, most recently from 63ac127 to cfb7079 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Unit tests and code fix for DATAREST-763.
Apologies I am unable to squash the commits at present as I'm working through the web UI due to access restrictions to gitHub.
This fix URL encodes/decodes entity ids to prevent the potential for invalid characters ending up in the URL. This is simply a case of encode/decode for all characters save for '/' which in its encoded form of %2F is not accepted by most webservers due to security issues (allowing for spurious modification of paths - partly what this change addresses from the DATAREST side!)
The proposed solution for this specific case is to double encode and decode the / --> %2F --> %252F which avoids this issue.