Remove memory leaks of RepositoryRestMvcConfig #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jbrisbin added a commit that referenced this pull request Jun 12, 2013
Remove memory leaks of RepositoryRestMvcConfig
| Thanks for the PR! |
| @ArloL can you verify that this leak is still gone in spring-data-rest 2.0.0.BUILD-SNAPSHOT? http://static.gueck.com/tmp/4/spring-boot-data-rest-memory-leak.html |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If you call getObject() directly on a FactoryBean it will create a memory leak because the bean is not managed by the application context.
Therefore I removed all calls to getObject() and let the context insert the dependency.
I tested this with my application using Tomcat 6 and jProfiler 6's Telemetry view. After a stop or undeploy the non-heap memory usage goes back down when running the GC.