DATAJDBC-573 - fixes the wait strategy for Oracle data sources. #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oracle integration tests where failing when the docker container was freshly started, as it happens every time on CI. The reason was mainly a misuse of Awaitility.ignoreException(Class) which only ignores exception of exactly the class provided, not of subtypes. Apart from fixing this for Oracle the complete logic for verifying the connection was moved to DataSourceConfiguration so other database use it as well in a consistent manner.
mp911de pushed a commit that referenced this pull request Jul 14, 2020
Oracle integration tests where failing when the docker container was freshly started, as it happens every time on CI. The reason was mainly a misuse of Awaitility.ignoreException(Class) which only ignores exception of exactly the class provided, not of subtypes. Apart from fixing this for Oracle the complete logic for verifying the connection was moved to DataSourceConfiguration so other database use it as well in a consistent manner. Original pull request: #237.
mp911de added a commit that referenced this pull request Jul 14, 2020
Remove unused imports, reformat code. Tweak logging. Original pull request: #237.
Member
| That's merged and polished now. |
mp911de added a commit that referenced this pull request Feb 21, 2022
mp911de pushed a commit that referenced this pull request Feb 21, 2022
Removed superfluous package name from `@Query` usage. Original pull request: #238.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Oracle integration tests where failing when the docker container was freshly started,
as it happens every time on CI.
The reason was mainly a misuse of
Awaitility.ignoreException(Class)which only ignores exception of exactly the class provided, not of subtypes.Apart from fixing this for Oracle the complete logic for verifying the connection was moved to DataSourceConfiguration so other database use it as well in a consistent manner.
DATAJDBC-573.