SqlIdentifierParameterSource now sanitizes identifier names #1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mipo256 approved these changes Jan 25, 2023
There was a problem hiding this comment.
That looks good.
Although I think it is worth to mention in documentation, that having columns, like first.name and first-name in the same table (the case that is highly unlikely to occur, but still) might cause weird behavior, since both of them will be resolved as firstname in parameter source.
In any case, up to you @schauder :)
| That's merged, polished, and backported now. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
superseeds #1406
Closes #1405