Skip to content

Conversation

@mipo256
Copy link
Contributor

@mipo256 mipo256 commented Jan 8, 2023

I have clarified (at least from my perspective) on what the license file should contain. I guess it could help future developers

@mipo256 mipo256 marked this pull request as ready for review January 8, 2023 13:35
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 8, 2023
@mipo256
Copy link
Contributor Author

mipo256 commented Jan 27, 2023

I have made the same changes in the #1403, so I will close it

@mipo256 mipo256 closed this Jan 27, 2023
@schauder
Copy link
Contributor

Plea

@schauder schauder reopened this Jan 27, 2023
@schauder
Copy link
Contributor

Please don't mix different concerns in a single PR.

@mipo256
Copy link
Contributor Author

mipo256 commented Jan 27, 2023

Ok, can you please review it then @schauder? I will remove this changes from #1286 PR

@schauder
Copy link
Contributor

Thanks, that's polished and merged.

@schauder schauder closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

3 participants