DATAREDIS-564 - Delegate expire(…) to pExpire if timeout exceeds Integer.MAX_VALUE. #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…pelining can cause NPE.
…ger.MAX_VALUE. Remove pExpireAt workaround that can lead to NullPointerException if called within a transaction/pipeline. Calls to expire(…) with a timeout greater Integer.MAX_VALUE are delegated to pExpire converting seconds to milliseconds. Related ticket: DATAREDIS-286.
christophstrobl pushed a commit that referenced this pull request Jan 13, 2017
…ger.MAX_VALUE. Remove pExpireAt workaround that can lead to NullPointerException if called within a transaction/pipeline. Calls to expire(…) with a timeout greater Integer.MAX_VALUE are delegated to pExpire converting seconds to milliseconds. Related ticket: DATAREDIS-286. Original Pull Request: #228
christophstrobl added a commit that referenced this pull request Jan 13, 2017
Remove white spaces, update license header. Add ticket reference to existing testcase. Original Pull Request: #228
christophstrobl pushed a commit that referenced this pull request Jan 13, 2017
…ger.MAX_VALUE. Remove pExpireAt workaround that can lead to NullPointerException if called within a transaction/pipeline. Calls to expire(…) with a timeout greater Integer.MAX_VALUE are delegated to pExpire converting seconds to milliseconds. Related ticket: DATAREDIS-286. Original Pull Request: #228
christophstrobl added a commit that referenced this pull request Jan 13, 2017
Update license header. Add ticket reference to existing testcase. Original Pull Request: #228
christophstrobl pushed a commit that referenced this pull request Jan 13, 2017
…ger.MAX_VALUE. Remove pExpireAt workaround that can lead to NullPointerException if called within a transaction/pipeline. Calls to expire(…) with a timeout greater Integer.MAX_VALUE are delegated to pExpire converting seconds to milliseconds. Related ticket: DATAREDIS-286. Original Pull Request: #228
christophstrobl added a commit that referenced this pull request Jan 13, 2017
Remove white spaces, update license header. Add ticket reference to existing testcase. Original Pull Request: #228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove
pExpireAtworkaround that can lead toNullPointerExceptionif called within a transaction/pipeline. Calls toexpire(…)with a timeout greaterInteger.MAX_VALUEare delegated topExpireconverting seconds to milliseconds.Related ticket: DATAREDIS-564.