DATAREDIS-547 - Fix query execution when derived criteria is empty. #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ny criteria. Prepare issue branch.
We now make sure to pipe finder queries without any criteria to the according find all method. This allows usage of `PagingAndSortingRepository.findAllBy(Pageable page)` as well as finders without any criteria like `findTop3By()`.
Return empty list if offset is greater than the available data set. Update supported keywords in reference docs.
mp911de force-pushed the issue/DATAREDIS-547 branch from 1240d8f to 71bbcbf Compare mp911de pushed a commit that referenced this pull request Sep 12, 2016
We now make sure to pipe finder queries without any criteria to the according find all method. This allows usage of `PagingAndSortingRepository.findAllBy(Pageable page)` as well as finders without any criteria like `findTop3By()`. Original pull request: #216.
mp911de added a commit that referenced this pull request Sep 12, 2016
Return empty list if offset is greater than the available data set. Update supported keywords in reference docs. Original pull request: #216.
| That's merged. |
mp911de pushed a commit that referenced this pull request Sep 12, 2016
We now make sure to pipe finder queries without any criteria to the according find all method. This allows usage of `PagingAndSortingRepository.findAllBy(Pageable page)` as well as finders without any criteria like `findTop3By()`. Original pull request: #216.
mp911de added a commit that referenced this pull request Sep 12, 2016
Return empty list if offset is greater than the available data set. Update supported keywords in reference docs. Original pull request: #216.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We now make sure to pipe finder queries without any criteria to the according find all method. This allows usage of
PagingAndSortingRepository.findAllBy(Pageable page)as well as finders without any criteria likefindTop3By().Depends on: spring-projects/spring-data-keyvalue#22