DATAREDIS-463 - Improve test synchronization. #171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Prepare issue branch.
Several tests rely heavily on time to perform synchronization. This leads to an increased test duration and in some cases to failed test. In some cases time is the only possibility to attempt synchronization. Remove Thread.sleep from tests which do not require a sleep at all. Use a condition where possible. Increase timeouts on tests known to fail very likely due to a short Thread.sleep.
christophstrobl pushed a commit that referenced this pull request Feb 18, 2016
Several tests rely heavily on time to perform synchronization. Therfore we remove Thread.sleep from tests which do not require a sleep at all, use a condition where possible and increase timeouts on tests known to fail very likely due to a short Thread.sleep. Original Pull Request: #171
christophstrobl pushed a commit that referenced this pull request Feb 22, 2016
Several tests rely heavily on time to perform synchronization. Therfore we remove Thread.sleep from tests which do not require a sleep at all, use a condition where possible and increase timeouts on tests known to fail very likely due to a short Thread.sleep. Original Pull Request: #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Several tests rely heavily on time to perform synchronization. This leads to an increased test duration and in some cases to failed tests. In some cases time is the only possibility to attempt synchronization.
Remove Thread.sleep from tests which do not require a sleep at all. Use a condition where possible. Increase timeouts on tests known to fail very likely due to a short Thread.sleep.