DATAREDIS-374 - Adapt JedisConnectionFactory for changes in Jedis 2.7. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
| Am I wrong or is jedis 2.7 still under development... Besides that the change redis/jedis@3032c94 involved more than just |
| We're forcusing our plan to 3.0.0 and we don't discuss about releasing 2.7 yet. |
| thanks @HeartSaVioR ! |
added 2 commits March 18, 2015 11:58
Prepare issue branch.
Previously we didn’t support Jedis 2.7 since the {{getTimeout}} / {{setTimeout}} Methods on {{JedisShardInfo}} to configure the {{SoTimeout}} were replaced by {{getSoTimeout}} and {{setSoTimeout}} respectively. We now detect the appropriate Methods via Reflection in JedisConnectionFactory. Tested against Jedis 2.7 branch with Redis 3.0.0.RC4. 
thomasdarimont force-pushed the issue/DATAREDIS-374 branch from 60af92b to ba09b82 Compare thomasdarimont pushed a commit that referenced this pull request Mar 19, 2015
We now support both Jedis 2.6.2 (current release) as well as the upcoming 2.7 version. Therefore we call the in 2.7 renamed `getTimeout` / `setTimeout` Methods on `JedisShardInfo` via reflection to read/set `soTimeout`. Since there’s no change in r.c.j.JedisFactory that would allow to individually configure connection and socket timeout, we use the socketTimeout of `JedisShardInfo`. This will cause `r.c.j.JedisFactory` to use the socket timeout for the connection as well, which is the same behavior as in 2.6.2. Tested against Jedis 2.7 branch with Redis 3.0.0.RC4. Original Pull Request: #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously we didn’t support Jedis 2.7 since the {{getTimeout}} / {{setTimeout}} Methods on {{JedisShardInfo}} to configure the {{SoTimeout}} were replaced by {{getSoTimeout}} and {{setSoTimeout}} respectively.
We now detect the appropriate Methods via Reflection in JedisConnectionFactory.
Tested against Jedis 2.7 branch with Redis 3.0.0.RC4.