Skip to content

Added new test cases #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Added new test cases #2868

wants to merge 4 commits into from

Conversation

@Shivang-X
Copy link

@Shivang-X Shivang-X commented Mar 1, 2024 •
edited
Loading

  • You have read the Spring Data Neo4j contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

I have figured out missing testcases in classes SpatialTypes, Coordinate, PointerBuilder and have written test cases for those classes.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 1, 2024
@michael-simons
Copy link
Collaborator

michael-simons commented Apr 2, 2024

Thank you for your effort, but we are not gonna merge those tests just to have more tests. The core functionality of those classes is covered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

3 participants

@Shivang-X @michael-simons @spring-projects-issues