Add Spring Framework AOT support. #2566
Conversation
christophstrobl left a comment
christophstrobl left a comment There was a problem hiding this comment.
left a few comments - other than that LGTM.
| protected void contribute(AotRepositoryContext repositoryContext, GenerationContext generationContext) { | ||
| super.contribute(repositoryContext, generationContext); | ||
| | ||
| repositoryContext.getResolvedTypes().stream().filter(Neo4jAotPredicates.IS_SIMPLE_TYPE.negate()).forEach(type -> { |
There was a problem hiding this comment.
is the filter in data commons too restrictive? Which additional types are you expecting to cover here?
There was a problem hiding this comment.
TBH, I took this from the mongo commit ;)
If this is not needed, I can remove it.
There was a problem hiding this comment.
In that case you man want to remove the entire processor as well as the reference to it in Neo4jRepositoryConfigurationExtension.java and just rely on the inspection done in data-commons.
less code :)
| import org.springframework.data.aot.TypeContributor; | ||
| | ||
| /** | ||
| * @author Gerrit Meier |
There was a problem hiding this comment.
@since tags would be nice to have.
| TypeReference.of(SimpleQueryByExampleExecutor.class), | ||
| TypeReference.of(BeforeBindCallback.class), | ||
| TypeReference.of(AfterConvertCallback.class), | ||
| // todo "temporary" fix, should get resolved when defined in @GeneratedValue |
There was a problem hiding this comment.
please create an issue in spring-projects/spring-data-commons for this, so we can keep track of the progress there.
| /** | ||
| * @author Gerrit Meier | ||
| */ | ||
| public class DataNeo4jRuntimeHints implements RuntimeHintsRegistrar { |
There was a problem hiding this comment.
maybe just Neo4jRuntimeHints?
Those things that we do to support AOT 😄