Skip to content

Conversation

@juergenzimmermann
Copy link

A PR for https://jira.spring.io/browse/DATAMONGO-2507 to add a default method accepting a CriteriaDefinition on ReactiveFindOperation.DistinctWithQuery.

  • [ x] You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [ x] You submit test cases (unit or integration tests) that back your changes.
  • [ x] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
@pivotal-issuemaster
Copy link

@juergenzimmermann Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@juergenzimmermann
Copy link
Author

@christophstrobl I don't know why there was a test failure in ChangeStreamTests.mapsTypedAggregationToFilterMessages » PreconditionViolation. I didn't change anything in this class.

christophstrobl pushed a commit that referenced this pull request Apr 14, 2020
…eactiveFindOperation.DistinctWithQuery. Original Pull Request: #852
christophstrobl added a commit that referenced this pull request Apr 14, 2020
Add 'matching' default method also to imperative variant (ExecutableFindOperation), fix & add tests using 'distinct'. Update Javadoc and rename input arg 'criteriaDefinition' to 'criteria'. Original Pull Request: #852
@christophstrobl
Copy link
Member

thanks @juergenzimmermann that's on master now!
Travis build fails quite often - the hook is likely to be removed in the future.

@juergenzimmermann
Copy link
Author

@christophstrobl I also want to submit a PR for Kotlin extension functions in GridFsTemplate. Do I start with a new fork from the master branch?

@christophstrobl
Copy link
Member

Sounds great!
You can sync your current fork with the upstream master and create a branch for the work on a new PR. Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants