DATAMONGO-2079 - MappingMongoConverter no longer implements ValueResolver #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…lver. MappingMongoConverter no longer implements a package-private interface so that converter instances can be proxied.
…nternal. Do not expose a method that is used internally.
| Nice! |
odrotbohm approved these changes Feb 4, 2020
| Looks generally good to me but don't want to get into the way of a final vote by @christophstrobl. |
christophstrobl pushed a commit that referenced this pull request Feb 4, 2020
…lver. MappingMongoConverter no longer implements a package-private interface so that converter instances can be proxied. Original Pull Request: #832
christophstrobl pushed a commit that referenced this pull request Feb 4, 2020
…nternal. Do not expose a method that is used internally. Original Pull Request: #832
christophstrobl pushed a commit that referenced this pull request Feb 4, 2020
…lver. MappingMongoConverter no longer implements a package-private interface so that converter instances can be proxied. Original Pull Request: #832
christophstrobl pushed a commit that referenced this pull request Feb 4, 2020
…lver. MappingMongoConverter no longer implements a package-private interface so that converter instances can be proxied. Original Pull Request: #832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
MappingMongoConverterno longer implements a package-private interface so that converter instances can be proxied.Related ticket: DATAMONGO-2079.
Should be backported to 2.1.x and 2.2.x. 6946c24 should be merged only for 3.0.