DATAMONGO-1492 - Make o.s.d.m.core.aggregation.AggregationExpression public. #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…d be public. Prepare issue branch.
…public. By turning `AggregationExpression` public we allow adding custom expressions without workarounds. It is now possible to create eg. `ProjectionOperation` like: ProjectionOperation agg = Aggregation.project() .and(new AggregationExpression() { @OverRide public DBObject toDbObject(AggregationOperationContext context) { DBObject filterExpression = new BasicDBObject(); filterExpression.put("input", "$x"); filterExpression.put("as", "y"); filterExpression.put("cond", new BasicDBObject("$eq", Arrays.<Object> asList("$$y.z", 2))); return new BasicDBObject("$filter", filterExpression); } }).as("profile"); 
mp911de pushed a commit that referenced this pull request Sep 19, 2016
…public. By turning `AggregationExpression` public we allow adding custom expressions without workarounds. It is now possible to create eg. `ProjectionOperation` like: ProjectionOperation agg = Aggregation.project() .and(new AggregationExpression() { @OverRide public DBObject toDbObject(AggregationOperationContext context) { DBObject filterExpression = new BasicDBObject(); filterExpression.put("input", "$x"); filterExpression.put("as", "y"); filterExpression.put("cond", new BasicDBObject("$eq", Arrays.<Object> asList("$$y.z", 2))); return new BasicDBObject("$filter", filterExpression); } }).as("profile"); Original pull request: #392. mp911de pushed a commit that referenced this pull request Sep 19, 2016
…public. By turning `AggregationExpression` public we allow adding custom expressions without workarounds. It is now possible to create eg. `ProjectionOperation` like: ProjectionOperation agg = Aggregation.project() .and(new AggregationExpression() { @OverRide public DBObject toDbObject(AggregationOperationContext context) { DBObject filterExpression = new BasicDBObject(); filterExpression.put("input", "$x"); filterExpression.put("as", "y"); filterExpression.put("cond", new BasicDBObject("$eq", Arrays.<Object> asList("$$y.z", 2))); return new BasicDBObject("$filter", filterExpression); } }).as("profile"); Original pull request: #392. mp911de pushed a commit that referenced this pull request Sep 19, 2016
…public. By turning `AggregationExpression` public we allow adding custom expressions without workarounds. It is now possible to create eg. `ProjectionOperation` like: ProjectionOperation agg = Aggregation.project() .and(new AggregationExpression() { @OverRide public DBObject toDbObject(AggregationOperationContext context) { DBObject filterExpression = new BasicDBObject(); filterExpression.put("input", "$x"); filterExpression.put("as", "y"); filterExpression.put("cond", new BasicDBObject("$eq", Arrays.<Object> asList("$$y.z", 2))); return new BasicDBObject("$filter", filterExpression); } }).as("profile"); Original pull request: #392. 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
By turning
AggregationExpressionpublic we allow adding custom expressions without workarounds. It is now possible to create eg.ProjectionOperationlike:should be back ported to 1.9.x and 1.8.x.