Skip to content

Conversation

boly38
Copy link
Contributor

@boly38 boly38 commented Feb 25, 2021

Closes #3568

Improve MongoExceptionTranslator to accept direct children is some case. First use case : MongoSocketException, MongoSocketException$children.

NB/ historical contributors of this class: @christophstrobl, @michalvich, @odrotbohm (Oliver Gierke)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 25, 2021
@boly38
Copy link
Contributor Author

boly38 commented Feb 25, 2021

(sorry I'm new on this project) I'm unable to see UT+IT results from github PR checks list. Are they executed somewhere?

Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. We don't have a build for pull requests. You can run the build locally if you spin up a MongoDB 4.x server locally.

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 1, 2021
@boly38 boly38 requested a review from mp911de March 1, 2021 22:32
@mp911de mp911de changed the title Improve MongoExceptionTranslator to accept MongoSocketException children. Translate MongoSocketException subclasses to DataAccessResourceFailureException Mar 2, 2021
@mp911de mp911de added this to the 3.0.8 (Neumann SR8) milestone Mar 2, 2021
mp911de pushed a commit that referenced this pull request Mar 2, 2021
mp911de added a commit that referenced this pull request Mar 2, 2021
Reformat code. Reduce method visibility in JUnit 5 tests. Add Nullable annotations to address warnings. See #3568 Original pull request: #3569.
@mp911de
Copy link
Member

mp911de commented Mar 2, 2021

Thank you for your contribution. That's merged, polished, and backported now.

mp911de pushed a commit that referenced this pull request Mar 2, 2021
mp911de added a commit that referenced this pull request Mar 2, 2021
Reformat code. Reduce method visibility in JUnit 5 tests. Add Nullable annotations to address warnings. See #3568 Original pull request: #3569.
@mp911de mp911de closed this Mar 2, 2021
mp911de pushed a commit that referenced this pull request Mar 2, 2021
mp911de added a commit that referenced this pull request Mar 2, 2021
Reformat code. Reduce method visibility in JUnit 5 tests. Add Nullable annotations to address warnings. See #3568 Original pull request: #3569.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

3 participants