DATAMONGO-1025 - Fix creation of nested named index. #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Prepare issue branch.
We new prefix explicitly named indexes on nested types (eg. for embedded properties) with the path pointing to the property. This avoids errors having equally named index definitions on different paths pointing to the same type within one collection. Along the way we harmonized index naming for geospatial index definitions where only the properties field name was taken into account where it should have been the full property path.
Deprecated `collection` attribute for @indexed, @CompoundIndex, @GeoSpatialIndexed. Removed deprecated attribute `expireAfterSeconds` from @CompoundIndex.
christophstrobl added a commit that referenced this pull request Aug 26, 2014
We new prefix explicitly named indexes on nested types (eg. for embedded properties) with the path pointing to the property. This avoids errors having equally named index definitions on different paths pointing to the same type within one collection. Along the way we harmonized index naming for geospatial index definitions where only the properties field name was taken into account where it should have been the full property path. Original pull request: #219.
christophstrobl added a commit that referenced this pull request Aug 26, 2014
We new prefix explicitly named indexes on nested types (eg. for embedded properties) with the path pointing to the property. This avoids errors having equally named index definitions on different paths pointing to the same type within one collection. Along the way we harmonized index naming for geospatial index definitions where only the properties field name was taken into account where it should have been the full property path. Original pull request: #219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We now prefix explicitly named indexes on nested types (eg. for embedded properties) with the path pointing to the property. This avoids errors having equally named index definitions on different paths pointing to the same type within one collection.
Along the way we harmonized index naming for geospatial index definitions where only the properties field name was taken into account where it should have been the full property path.
Deprecated
collectionattribute for@Indexed,@CompoundIndexand@GeoSpatialIndexed.Removed attribute
expireAfterSecondsfrom@CompoundIndex.Note: It might happen that one has to explicitly drop some of the already created index structures in order the get the build working as index structures changed due to the removal of the ttl attribute.
cbbb293 should be back ported to
1.5.x- some minor glitches there but doable.