Skip to content

Reintroduce Specification.where(Specification) #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reintroduce Specification.where(Specification) #3998

wants to merge 1 commit into from

Conversation

@nam0oo
Copy link
Contributor

@nam0oo nam0oo commented Aug 29, 2025

Reintroduce the Specification.where(Specification) overload to improve the migration path for users upgrading to Spring Data JPA 4.0 and to restore the intuitive fluent API.

Closes #3992

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2025
@injae-kim injae-kim mentioned this pull request Aug 29, 2025
Closed
@nam0oo
Reintroduce Specification.where(Specification)
364fdb9 
Reintroduce the overload to improve the migration path for users upgrading to Spring Data JPA 4.0 and to restore the intuitive fluent API. Closes spring-projects#3992 Signed-off-by: 희은 <datakubit2@gmail.com>
@nam0oo nam0oo force-pushed the enhancement/3992-reintroduce-spec-where branch from 2798624 to 364fdb9 Compare August 29, 2025 06:26
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 1, 2025
@mp911de mp911de self-assigned this Sep 1, 2025
@mp911de mp911de added this to the 4.0 M6 (2025.1.0) milestone Sep 1, 2025
mp911de pushed a commit that referenced this pull request Sep 1, 2025
@nam0oo @mp911de
Reintroduce Specification.where(Specification)
a1fbb5a 
Reintroduce the overload to improve the migration path for users upgrading to Spring Data JPA 4.0 and to restore the intuitive fluent API but this time, the method does not accept null values. Closes #3992 Original pull request: #3998 Signed-off-by: 희은 <datakubit2@gmail.com>
mp911de added a commit that referenced this pull request Sep 1, 2025
@mp911de
Polishing.
f50d356 
Reinstate original Javadoc, add note about nullability. Fix contract annotation, refine tests. See #3992 Original pull request: #3998
@mp911de
Copy link
Member

mp911de commented Sep 1, 2025

Thank you for your contribution. That's merged and polished now.
@mp911de mp911de closed this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

3 participants

@nam0oo @mp911de @spring-projects-issues