page number JavaDoc: positive -> non-negative #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…e, and therefore non-negative; not positive.
| Fixed, thanks! |
Aloren pushed a commit to Aloren/spring-data-commons that referenced this pull request Jun 20, 2019
By default, creates a RestTemplateCustomizer adds a LoadBalancerInterceptor fixes spring-projectsgh-16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was confused for a day or two from reading this JavaDoc and thinking that page numbers for PagingAndSortingRepositories were 1-based rather than 0-based. My JUnit test suggests strongly that they are 0-based, so I changed the JavaDoc to read "non-negative" rather than positive.