Fix Assert.notNull performed on the error message #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for the PR. That's an obvious fix, so no tests/author tags/... required. |
mp911de pushed a commit that referenced this pull request Jul 21, 2016
…etWhereClauses(…). Assert.notNull now checks the id parameter in MappingCassandraConverter.getWhereClauses(…). Original pull request: #77.
| That's merged with 6e176ba. |
| Thanks, that's indeed what I figured, so decided to hold off on doing the tests/author tags/copyright date/JIRA etc. until I heard something. No problem, of course! |
jxblum added a commit to jxblum/spring-data-cassandra that referenced this pull request Jul 25, 2016
…ion options to CassandraCqlClusterFactoryBean. Original pull request: spring-projects#77.
jxblum added a commit to jxblum/spring-data-cassandra that referenced this pull request Jul 25, 2016
…e to handle extended configuration when the DataStax API changes. Original pull request: spring-projects#77.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed something wasn't quite right, will update pull request accordingly as I complete side tasks.
You have read the Spring Data contribution guidelines.
There is a ticket in the bug tracker for the project in our JIRA.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
You provide your full name and an email address registered with your GitHub account. If you’re a first-time submitter, make sure you have completed the Contributor’s License Agreement form.