Skip to content

DATACASS-814 - MapPreparedStatementCache.CacheKey uses #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DATACASS-814 - MapPreparedStatementCache.CacheKey uses #180

wants to merge 1 commit into from

Conversation

@aldobongio
Copy link
Contributor

DefaultSimpleStatement.toString() inherited from Object.toString()

  • [X ] You have read the Spring Data contribution guidelines.
  • [ X] There is a ticket in the bug tracker for the project in our JIRA.
  • [ X] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [ X] You submit test cases (unit or integration tests) that back your changes.
  • [ X] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
@aldobongio
DATACASS-814 - MapPreparedStatementCache.CacheKey uses
13f8c22 
DefaultSimpleStatement.toString() inherited from Object.toString()
@pivotal-issuemaster
Copy link

@aldobongio Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.
@pivotal-issuemaster
Copy link

@aldobongio Thank you for signing the Contributor License Agreement!
mp911de pushed a commit that referenced this pull request Oct 23, 2020
@aldobongio @mp911de
DATACASS-814 - Use CQL in MapPreparedStatementCache.CacheKey instead …
d4a5c09 
…representation of Object.toString(). We now correctly use the CQL text to cache prepared statements. Previously, we used toString() which was a leftover from the driver migration that now defaults to Object.toString() and so the cache key was not stable. Original pull request: #180.
mp911de added a commit that referenced this pull request Oct 23, 2020
@mp911de
DATACASS-814 - Polishing.
f0342e6 
Fix typo in docs. Convert space indents to tabs. Original pull request: #180.
mp911de pushed a commit that referenced this pull request Oct 23, 2020
@aldobongio @mp911de
DATACASS-814 - Use CQL in MapPreparedStatementCache.CacheKey instead …
3b05815 
…representation of Object.toString(). We now correctly use the CQL text to cache prepared statements. Previously, we used toString() which was a leftover from the driver migration that now defaults to Object.toString() and so the cache key was not stable. Original pull request: #180.
mp911de added a commit that referenced this pull request Oct 23, 2020
@mp911de
DATACASS-814 - Polishing.
857bde1 
Fix typo in docs. Convert space indents to tabs. Original pull request: #180.
@mp911de
Copy link
Member

mp911de commented Oct 23, 2020

Thank you for your contribution. That's merged, polished, and backported now.
@mp911de mp911de closed this Oct 23, 2020
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@aldobongio @pivotal-issuemaster @mp911de