Skip to content

Wording changes #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Wording changes #176

wants to merge 1 commit into from

Conversation

Buzzardo
Copy link

@Buzzardo Buzzardo commented Jun 25, 2020 •
edited
Loading

Replace potentially insensitive language with more neutral language.

Note that problematic words in the code have
to remain in the docs until the code changes.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
Wording changes
917571a 
Removed the language of oppression and violence and replaced it with more neutral language. Note that problematic words in the code have to remain in the docs until the code changes.
mp911de
mp911de reviewed Jul 27, 2020
View reviewed changes
src/main/asciidoc/reference/migration-guide-2.2-to-3.0.adoc
=== Utilities

* `GuavaListenableFutureAdapter`
* `QueryOptions` and `WriteOptions` constructor taking `ConsistencyLevel` and `RetryPolicy` arguments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to stick with executionProfile as that's part of the Cassandra driver API: https://docs.datastax.com/en/drivers/java/4.6/com/datastax/oss/driver/api/core/cql/StatementBuilder.html#executionProfile
mp911de
mp911de reviewed Jul 27, 2020
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. We can proceed here with a single exception where we need to stick with wording provided by the driver API.
mp911de pushed a commit that referenced this pull request Oct 23, 2020
@mp911de
DATACASS-816 - Wording changes.
13e168a 
Removed the language of oppression and violence and replaced it with more neutral language. Note that problematic words in the code have to remain in the docs until the code changes. Original pull request: #176.
mp911de added a commit that referenced this pull request Oct 23, 2020
@mp911de
DATACASS-816 - Polishing.
b0d6180 
Original pull request: #176.
mp911de pushed a commit that referenced this pull request Oct 23, 2020
@mp911de
DATACASS-816 - Wording changes.
0b1fcb6 
Removed the language of oppression and violence and replaced it with more neutral language. Note that problematic words in the code have to remain in the docs until the code changes. Original pull request: #176.
mp911de added a commit that referenced this pull request Oct 23, 2020
@mp911de
DATACASS-816 - Polishing.
73ffe7d 
Original pull request: #176.
@mp911de
Copy link
Member

mp911de commented Oct 23, 2020

Thank you for your contribution. That's merged, polished, and backported now.
@mp911de mp911de closed this Oct 23, 2020
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Buzzardo @mp911de