DATACASS-599 Restore compatibility with Guava 26+ #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Guava has removed Futures#transform method without the Executor parameter in version 26.0-jre DefaultBridgeReactiveSession fails with NoSuchMethod exception when used with Guava 26.0-jre+.
mp911de pushed a commit that referenced this pull request Feb 6, 2019
Guava has removed Futures#transform method without the Executor parameter in version 26.0-jre DefaultBridgeReactiveSession fails with NoSuchMethod exception when used with Guava 26.0-jre+. Original pull request: #137.
mp911de added a commit that referenced this pull request Feb 6, 2019
Add executor to other Futures.transform(…) and Futures.addCallback(…) invocations. Original pull request: #137.
mp911de pushed a commit that referenced this pull request Feb 6, 2019
Guava has removed Futures#transform method without the Executor parameter in version 26.0-jre DefaultBridgeReactiveSession fails with NoSuchMethod exception when used with Guava 26.0-jre+. Original pull request: #137.
mp911de added a commit that referenced this pull request Feb 6, 2019
Add executor to other Futures.transform(…) and Futures.addCallback(…) invocations. Original pull request: #137.
mp911de pushed a commit that referenced this pull request Feb 6, 2019
Guava has removed Futures#transform method without the Executor parameter in version 26.0-jre DefaultBridgeReactiveSession fails with NoSuchMethod exception when used with Guava 26.0-jre+. Original pull request: #137.
mp911de added a commit that referenced this pull request Feb 6, 2019
Add executor to other Futures.transform(…) and Futures.addCallback(…) invocations. Original pull request: #137.
| Thanks a lot. That's merged, polished and backported now. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Guava has removed Futures#transform method without the Executor parameter in version 26.0-jre.
DefaultBridgeReactiveSession fails with NoSuchMethod exception when used with Guava 26.0-jre+.