DATACASS-576 - Add support for Optimistic Locking. #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… UPDATE and DELETE. We now support conditions in lightweight transactions for UPDATE and DELETE statements. Conditions are Filter objects similar to the WHERE clause. Conditions are supported for entity- and query-based update/delete methods. UpdateOptions options = UpdateOptions.builder().ifCondition(where("firstname").is("Walter")).build(); User user = new User("heisenberg", "Walter", "White"); template.update(user, options); DeleteOptions options = DeleteOptions.builder().ifCondition(where("counter").is(42)).build(); Query query = Query.query(where("id").is("heisenberg")).queryOptions(options); template.delete(query, User.class); We now support Optimistic Locking for insert, update and delete operations leveraging Cassandra's lightweight transaction support. Modifying statements are enhanced with IF conditions to conditionally insert and modify rows and to prevent concurrent modifications by throwing OptimisticLockingFailureException. @table class Person { @id String id; String firstname; String lastname; @Version Long version; } Person daenerys = template.insert(new Person("Daenerys")); Person tmp = template.findOne(query(where("id").is(daenerys.getId())), Person.class); daenerys.setLastname("Targaryen"); template.save(daenerys); template.save(tmp); // throws OptimisticLockingFailureException
Formatting. Reorder methods for consistent method ordering.
mp911de force-pushed the issue/DATACASS-576 branch from 96a4b8c to d33c19a Compare 
| We may want to consider support for version properties other than of type Often times, it is even useful to use multiple properties in optimistic locking (e.g. user + timestamp). Our initial implementation should satisfy most UCs for the time being. |
| @jxblum care to file a ticket against Spring Data Commons to discuss the idea? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We now support Optimistic Locking for insert, update and delete operations leveraging Cassandra's lightweight transaction support. Modifying statements are enhanced with
IFconditions to conditionally insert and modify rows and to prevent concurrent modifications by throwingOptimisticLockingFailureException.Depends on: DATACASS-575, #135.
Related ticket: DATACASS-576.