Skip to content

Reuse User Defined Conversion Service. #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reuse User Defined Conversion Service. #1344

wants to merge 1 commit into from

Conversation

neshkeev
Copy link

@neshkeev neshkeev commented Jan 15, 2023 •
edited
Loading

Users used to be unable to define their own conversion service beans, because MappingCassandraConverter always used to create a new instance regardless of whether there is a bean with such a type or not. Now an object for conversion service is created only if there are no such a bean defined.

NOTICE I don't expect it to be the best solution possible, I'm open for a dialog to make the PR and related code better

Related tickets #1343

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2023
@neshkeev
Reuse User Defined Conversion Service.
9d42cec 
Users used to be unable to defined their own conversion service beans, because MappingCassandraConverter always used to create a new instance regardless of whether there is a bean with such a type or not. Now an object for conversion service is created only if there are no such a bean defined. Closes tickets #1343 Signed-off-by: Nikita Eshkeev <neshkeev@yandex.ru>
@mp911de mp911de added the status: blocked An issue that's blocked on an external project change label Jan 23, 2023
@mp911de mp911de linked an issue Jan 23, 2023 that may be closed by this pull request
User Defined ConversionService is ignored #1343
Closed
@mp911de mp911de self-assigned this Apr 24, 2023
@mp911de
Copy link
Member

mp911de commented May 10, 2023

Closing as per #1343 (comment)
@mp911de mp911de closed this May 10, 2023
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: blocked An issue that's blocked on an external project change status: waiting-for-triage An issue we've not yet triaged labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

3 participants

@neshkeev @mp911de @spring-projects-issues