Skip to content

Conversation

@OlegDokuka
Copy link
Contributor Author

@mp911de ready to review.

Do we really need support for inserting Publisher? From my perspective, we will be able to execute elements draining only on the .execute method invocation. In turn, it will not give any benefits since we will have to collect data before writing, so in any case, it will be kind of "waiting point" + there is danger point that one sent infinitive stream, etc

@mp911de
Copy link
Member

mp911de commented Jul 20, 2018

Thanks for raising this item. Accepting Publisher is an optimization which brings a challenge of batching and awaiting. In MongoDB, we switched to accept Mono<List<T>> to allow deferred inserts. Using the API would require to collect items upfront (.buffer() or .collectList()) and pass in the collected objects for a batch.

For the start, we're good without accepting Publisher.

@OlegDokuka
Copy link
Contributor Author

I will add support for Publisher. Let me check Mongo api first in order to be aligned.

@OlegDokuka
Copy link
Contributor Author

@mp911de done

@mp911de
Copy link
Member

mp911de commented Jul 23, 2018

Thanks a lot. We're heading right now towards 2.1 RC1 so this pull request is a candidate for the second release candidate, 2.1 RC2.

@OlegDokuka
Copy link
Contributor Author

@mp911de Great! Do I need to add/change something there or it is good to good but will be merged later?

@mp911de
Copy link
Member

mp911de commented Jul 23, 2018

I haven't reviewed the pull request yet as we're currently busy with preparing 2.1 RC1.

mp911de pushed a commit that referenced this pull request Aug 3, 2018
mp911de added a commit that referenced this pull request Aug 3, 2018
Reduce visibility of ReactiveCassandraBatchTemplate to package-private. Move registration of stream subscription to a deferred Mono to allow multiple execute calls and only prevent multiple subscriptions. Convert spaces to tabs, formatting, javadoc, author and since tags. Original pull request: #134.
@mp911de
Copy link
Member

mp911de commented Aug 3, 2018

Thanks for your contribution. I had to convert spaces to tabs (please apply our formatting settings next time) and applied a round of polishing. You might be interested in 8055890.

That's merged and polished now.

@OlegDokuka
Copy link
Contributor Author

hey @mp911de. Thank you for polishing. Should I add something else there

@mp911de mp911de closed this Aug 6, 2018
@mp911de
Copy link
Member

mp911de commented Aug 6, 2018

Nothing left to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants