Skip to content

Conversation

@boutier
Copy link
Contributor

@boutier boutier commented Jan 28, 2021

Bug introduced by:

Introduces @Frozen annotation to mark schema elements as Frozen. (17adf20)

Discussed in #1084

@mp911de: I'm not sure how to test it. Probably something in ColumnTypeResolverUnitTests like the following, but could you please give me how to get a UDT CassandraType? (Or directly write the test)

@Test // DATACASS-743 void shouldReportMissingType() { CassandraType annotation; assertThatThrownBy(() -> resolver.resolve(annotation)).isInstanceOf(MappingException.class);	}
Bug introduced by: Introduces @Frozen annotation to mark schema elements as Frozen. (17adf20)
@pivotal-issuemaster
Copy link

@boutier Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 28, 2021
@boutier
Copy link
Contributor Author

boutier commented Jan 28, 2021

I'm not going to sign CLAs for pull requests: it is nonsense since a pull request import all changes from a repository, including licence changes, and, as we can see, there are no licence chances, so the pull request is under the same licence than the original code, i.e. Apache 2 in this case.

Please feel free to do what you deem right: pull from your local repo and then push (eh!), discard pull request, etc.

@mp911de
Copy link
Member

mp911de commented Jan 28, 2021

The CLA ensures that you grant us an inbound license to import your changes. In this case, we don't require a CLA because it's an obvious fix.

@mp911de
Copy link
Member

mp911de commented Jan 28, 2021

@pivotal-issuemaster this is an obvious fix.

@pivotal-issuemaster
Copy link

@boutier This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 29, 2021
@mp911de mp911de linked an issue Jan 29, 2021 that may be closed by this pull request
mp911de pushed a commit that referenced this pull request Jan 29, 2021
mp911de added a commit that referenced this pull request Jan 29, 2021
Replace duplicated code with method calls. Closes: #1084 Original pull request: #1085 Related ticket: DATACASS-465
mp911de pushed a commit that referenced this pull request Jan 29, 2021
mp911de added a commit that referenced this pull request Jan 29, 2021
Replace duplicated code with method calls. Closes: #1084 Original pull request: #1085 Related ticket: DATACASS-465
mp911de pushed a commit that referenced this pull request Jan 29, 2021
mp911de added a commit that referenced this pull request Jan 29, 2021
Replace duplicated code with method calls. Closes: #1084 Original pull request: #1085 Related ticket: DATACASS-465
@mp911de
Copy link
Member

mp911de commented Jan 29, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

4 participants