Harmonize Logback's console and file logging charset

[nosan]

See #44472

I wonder if DefaultLogbackConfiguration.java should be updated to use UTF-8 as well. If so, perhaps System.console().charset() should be used as the default for the console.

[mhalbritter]

I wonder if DefaultLogbackConfiguration.java should be updated to use UTF-8 as well

I think so. Right now, DefaultLogbackConfiguration uses Charset.defaultCharset().name(), but defaults.xml uses UTF-8.

[nosan]

Just to be on the same page, should DefaultLogbackConfiguration be updated to use the same values as defaults.xml?

At the moment, defaults.xml has the following values:

• ${CONSOLE_LOG_CHARSET:-${file.encoding:-UTF-8}}
• ${FILE_LOG_CHARSET:-${file.encoding:-UTF-8}}

[mhalbritter]

I'd use Console.charset() if that's available, otherwise the default charset. And UTF-8 for files.

That should align it with #44353 (comment)

[nosan]

Thanks, @mhalbritter
PR has been updated.

[nosan]

@snicoll
I am totally forgot to update DEFAULT_CHARSET = Charset.defaultCharset().name(); to UTF-8! Could you please update to UTF-8?

[nosan]

Tests work for me because UTF-8 is default locale on my laptop 🤦

[snicoll]

@nosan I was reviewing but feel free to push a fix, I'll wait

[nosan]

@snicoll
Fixed, FYI I did not squash commits.