Skip to content

StandardStackTracePrinter prints root first if configured otherwise #44398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

StandardStackTracePrinter prints root first if configured otherwise #44398

wants to merge 3 commits into from

Conversation

typat
Copy link
Contributor

@typat typat commented Feb 21, 2025 •
edited
Loading

Makes the StandardStackTracePrinter root option respect the logging.structured.json.stacktrace.root property value

I'm assuming based on the documentation that last should be the default value, which this respects

 Use `last` to print the root item last (same as Java) or `first` to print the root item first.
@typat
Update StructuredLoggingJsonProperties.java
82c2ddf 
Signed-off-by: Tyler Gregory <tyler.w.gregory@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2025
typat added 2 commits February 21, 2025 16:15
@typat
Update StructuredLoggingJsonPropertiesTests.java
a18fd9e 
Signed-off-by: Tyler Gregory <tyler.w.gregory@gmail.com>
@typat
remove new line
6bce1d5 
Signed-off-by: Tyler Gregory <tyler.w.gregory@gmail.com>
@mhalbritter mhalbritter self-assigned this Feb 25, 2025
@mhalbritter mhalbritter changed the title Ensure StandardStackTracePrinter respects stacktrace.root configuration property StandardStackTracePrinter prints root first if configured otherwise Feb 25, 2025
@mhalbritter mhalbritter added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 25, 2025
@mhalbritter mhalbritter added this to the 3.5.0-M3 milestone Feb 25, 2025
mhalbritter pushed a commit that referenced this pull request Feb 25, 2025
@typat @mhalbritter
Ensure StandardStackTracePrinter respects stacktrace.root configurati…
9199fec 
…on property See gh-44398 Signed-off-by: Tyler Gregory <tyler.w.gregory@gmail.com>
@mhalbritter
Copy link
Contributor

Thanks @typat !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

3 participants

@typat @mhalbritter @spring-projects-issues