X-Registry-Auth header sent to Docker Engine API contains field "authHeader" #42910
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Overview of Changes
@JsonIgnore
on variableauthHeader
to avoid auto-serialization.com.fasterxml.jackson.annotation.JsonIgnore
to make annotation valid../gradlew checkstyleMain
and./gradlew format
to fix style error.Related Issues
Fixed #42905
Type of Change
Impact
Now when class
DockerRegistryUserAuthentication
andDockerRegistryTokenAuthentication
use methodcreateAuthHeader()
would't add"authHeader" : null
field.Test
I've already test the class
DockerRegistryUserAuthentication
andDockerRegistryTokenAuthentication
methodgetAuthHeader()
, but only write rough test code not create a new branch to test. Do I need create a new branch?Effect of Test
Expected Result:
it works as expected.
Note
If anything I did worked not as expected, plz contact with me. Finally, looking forward to your reply.